Add paths in fileInDevice #113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR solves the bug from ticket https://inxt.atlassian.net/browse/PB-3776.
This solves also the issue #111.
Problem
Currently, we were using the property blocks of a file to difference between the event of fetch data (double click on a file) and hydratie (always keep on this device). However, zip files and maybe other files have 0 blocks always, so it wasn't working there.
Solution
Currently, there is a variable calle fileInDevice that manages files that are hydrated, however, it wasn't taking into account neither files that were hydrated in the initialization of the virtual drive nor files that were hydrated using fetch data (double click). We are going to fix this and that will fix also the bug, because we won't be looking anymore in the file stats, we will look only if the file is hydrated (is in the device) or not.